Inconsistent documentation on Parcel integration #1004
Comments
|
Sorry, example was created before we made some changes into Parcel, and we forget to remove comment later. |
timm-aym
pushed a commit
to timm-aym/react-hot-loader
that referenced
this issue
Jun 5, 2018
|
Thanks for responding so quickly! <3 |
pete-murphy
added a commit
to pete-murphy/purescript-parcel-example
that referenced
this issue
Oct 10, 2018
Fix browser refresh issue (justinwoo#2) by exporting "hot" module from `src/Main.purs`. (I think this is related to gaearon/react-hot-loader#1004.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description
In the README under "parcel", it tells me to follow step 1 & 2 of getting started. There it advises to hot export the root component.
On the linked parcel example though, it tells me
// DO NOT USE HOT!as a comment in the code.Which one should I believe? The README or the Code Comment?
If anyone knows this, please let me know. I'd be glad to submit a PR to remove this inconsistency accordingly.
The text was updated successfully, but these errors were encountered: