Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor project #844

Merged
merged 2 commits into from Feb 7, 2018

Conversation

@neoziro
Copy link
Collaborator

commented Feb 6, 2018

  • Refactor all project
  • Remove Lerna
  • Simplify code
@codecov-io

This comment has been minimized.

Copy link

commented Feb 6, 2018

Codecov Report

Merging #844 into next will decrease coverage by 0.09%.
The diff coverage is 37.5%.

Impacted file tree graph

@@            Coverage Diff            @@
##             next     #844     +/-   ##
=========================================
- Coverage   86.21%   86.12%   -0.1%     
=========================================
  Files          25       30      +5     
  Lines         573      598     +25     
  Branches      141      139      -2     
=========================================
+ Hits          494      515     +21     
- Misses         59       67      +8     
+ Partials       20       16      -4
Impacted Files Coverage Δ
src/internal/reactUtils.js 84.61% <ø> (ø)
src/internal/stack/hydrateLegacyStack.js 0% <ø> (ø)
src/hot.dev.js 91.42% <ø> (ø)
src/proxy/constants.js 100% <ø> (ø)
src/reconciler/proxyAdapter.js 94.44% <ø> (ø)
src/internal/stack/hydrateFiberStack.js 100% <ø> (ø)
src/reactHotLoader.js 100% <ø> (ø)
src/AppContainer.prod.js 100% <ø> (ø)
src/global/modules.js 100% <ø> (ø)
test/proxy/helper.js 100% <ø> (ø)
... and 39 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bf519d4...15200cc. Read the comment docs.

@neoziro neoziro force-pushed the wip-refactoring branch 2 times, most recently from 4513144 to 06acf6b Feb 6, 2018

"devDependencies": {
"babel-cli": "^6.7.5",
"babel-core": "^6.7.6",
"babel-eslint": "^8.2.1",
"babel-jest": "^22.1.0",
"babel-plugin-dynamic-import-node": "^1.2.0",
"babel-plugin-external-helpers": "^6.22.0",

This comment has been minimized.

Copy link
@theKashey

theKashey Feb 6, 2018

Collaborator

I've removed this plugin from rollup config, but not from the package json.

This comment has been minimized.

Copy link
@neoziro

neoziro Feb 6, 2018

Author Collaborator

Why?

This comment has been minimized.

Copy link
@theKashey

theKashey Feb 6, 2018

Collaborator

It has a side effect on the final bundle, causing this bug - storybookjs/storybook#1320

So, I've just removed it, and double check that bundle is ok-ish. Lets dont introduce some external stuff, the final customer should also inject in his code.

@@ -99,7 +99,7 @@ describe('hot (dev)', () => {
}, 1)
})

it('should trigger error in unmount in opened state', () => {
it.only('should trigger error in unmount in opened state', () => {

This comment has been minimized.

Copy link
@theKashey

theKashey Feb 6, 2018

Collaborator

My bad.

@@ -148,21 +148,21 @@ function inject(target, currentGeneration, injectedMembers) {
key,
`(function REACT_HOT_LOADER_SANDBOX () {
var _this = this; // common babel transpile
var _this2 = this; // common babel transpile
var _this2 = this; // common babel transpile

This comment has been minimized.

Copy link
@theKashey

theKashey Feb 6, 2018

Collaborator

This is ☠️, I know that _this3 exists.
In ideal we should or inject regenerate in a constructor, to make these variables visible, or detect the error on regenerate, and ask to disable arrow function transpiling.

@neoziro neoziro force-pushed the wip-refactoring branch from 85d5c80 to 7b08d07 Feb 6, 2018

feat: ship flat bundles
- Refactor all project
- Remove Lerna
- Simplify code

@neoziro neoziro force-pushed the wip-refactoring branch from 7b08d07 to 2ebdacd Feb 6, 2018

@neoziro neoziro merged commit 7580552 into next Feb 7, 2018

2 of 4 checks passed

codecov/patch 37.5% of diff hit (target 86.21%)
Details
codecov/project 86.12% (-0.1%) compared to bf519d4
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
continuous-integration/travis-ci/push The Travis CI build passed
Details

@neoziro neoziro deleted the wip-refactoring branch Feb 7, 2018

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants
You can’t perform that action at this time.