New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add more heuristic to routes patterns #182

Open
musketyr opened this Issue Dec 5, 2012 · 1 comment

Comments

Projects
None yet
2 participants
@musketyr
Contributor

musketyr commented Dec 5, 2012

some of pattern should be simplified if we use some heuristic in transformRouteIntoRegex

https://github.com/gaelyk/gaelyk/blob/master/core/src/main/groovyx/gaelyk/routes/Route.groovy#L109

e.g. before optimalization routes like **.groovy doesn't work at all (or last too long to process), because they were too complicated.

@erdi

This comment has been minimized.

Show comment
Hide comment
@erdi

erdi Dec 7, 2012

Contributor

I've just hit this issue while preparing for my GGX talk. The performance of those regular expressions is quite bad and this looks like a high priority issue as most of the requests have to go through routes filter. This should definitelly be fixed before next release. I don't have time to play with it ATM, but this is the first thing on my list for the weekend after GGX.

Contributor

erdi commented Dec 7, 2012

I've just hit this issue while preparing for my GGX talk. The performance of those regular expressions is quite bad and this looks like a high priority issue as most of the requests have to go through routes filter. This should definitelly be fixed before next release. I don't have time to play with it ATM, but this is the first thing on my list for the weekend after GGX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment