Handle lsp-use-plists being enabled #30
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sorry for the delay, I'll try to get to it this week (just to test it doesn't break anything) |
northgaard
pushed a commit
to northgaard/consult-lsp
that referenced
this pull request
Jul 29, 2022
gagbo
added a commit
that referenced
this pull request
Oct 19, 2022
When symbols span multiple lines, `cend` might be less than `cbeg`, so we must use the correct line of the symbol instead of assuming the symbol only lives on one line. Also, `consult-lsp--flatten-document-symbols` assumed that the return values from LSP requests was always a hash-table, so in the same vein as #30 we are changing the code to use lsp-mode-provided helpers. Closes: #33
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lsp-use-plistscan be used to speed up deserialization, but libraries must uselsp-getinstead ofgethashto abstract over the two possible representations.