Join GitHub today
GitHub is home to over 31 million developers working together to host and review code, manage projects, and build software together.
Sign upFix utf8 encoding problem #17
Conversation
at15
added some commits
Dec 5, 2015
This comment has been minimized.
This comment has been minimized.
|
e ... travis build for php5.5 fails, but 5.4 and 5.6 pass, strange ... |
gajus
added
the
enhancement
label
Dec 7, 2015
This comment has been minimized.
This comment has been minimized.
|
@at15 Have you figured out why Travis build for 5.5 is failing? |
This comment has been minimized.
This comment has been minimized.
|
@gajus from travis log
so travis run PHPUnit5.0+ on PHP 5.5 environment and thus failed, but I don't know why the previous builds pass on PHP 5.5, maybe because travis was still using PHPUnit4.x for PHP 5.5 at that time. And if we use |
This comment has been minimized.
This comment has been minimized.
KennedyTedesco
commented
Jan 14, 2016
|
|
Schleuse
referenced this pull request
Oct 10, 2018
Merged
Use local phpunit to mitigate problems with different php versions #31
This comment has been minimized.
This comment has been minimized.
|
Works like a charm |
gajus
merged commit c2beb72
into
gajus:master
Oct 10, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
at15 commentedDec 5, 2015
see #15 , when deal with utf8 encoding strings, it will get wrong output. add
usolve it. thanks to @eos-13 this pr should fix it.