New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix utf8 encoding problem #17

Merged
merged 3 commits into from Oct 10, 2018

Conversation

Projects
None yet
4 participants
@at15
Copy link
Contributor

at15 commented Dec 5, 2015

see #15 , when deal with utf8 encoding strings, it will get wrong output. add u solve it. thanks to @eos-13 this pr should fix it.

@at15

This comment has been minimized.

Copy link
Contributor Author

at15 commented Dec 5, 2015

e ... travis build for php5.5 fails, but 5.4 and 5.6 pass, strange ...

@gajus gajus added the enhancement label Dec 7, 2015

@gajus

This comment has been minimized.

Copy link
Owner

gajus commented Dec 7, 2015

@at15 Have you figured out why Travis build for 5.5 is failing?

@at15

This comment has been minimized.

Copy link
Contributor Author

at15 commented Dec 8, 2015

@gajus from travis log

This version of PHPUnit requires PHP 5.6; using the latest version of PHP is highly recommended.

so travis run PHPUnit5.0+ on PHP 5.5 environment and thus failed, but I don't know why the previous builds pass on PHP 5.5, maybe because travis was still using PHPUnit4.x for PHP 5.5 at that time.

And if we use requrie-dev and specify the phpunit version instead of using the global one, it should pass.

@KennedyTedesco

This comment has been minimized.

Copy link

KennedyTedesco commented Jan 14, 2016

👍

@Schleuse

This comment has been minimized.

Copy link
Contributor

Schleuse commented Oct 10, 2018

Works like a charm 🦄

@gajus gajus merged commit c2beb72 into gajus:master Oct 10, 2018

1 of 2 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
coverage/coveralls Coverage remained the same at 92.593%
Details

@at15 at15 referenced this pull request Oct 12, 2018

Closed

Weekly-96 #80

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment