Nonsensical special types are uncaught by `check-types`

[binury]

Recently we observed a developer, who was unfamiliar with JSDoc, attempt to define a type like this:

  /**
   * @param {Object<Object>}
   */

I thought it odd that this was not detected by the linter. I checked if this was a special case but found that there was no such check performed on special types because

  /**
   * @param {string<Object>}
   */

is also passed. 👎

  /**
   * @param {string<>}
   */

however is invalidated because the subtype is nonexistent. 👍

AFAIK special types apply in at least two cases:

1. Array and
2. Promise

would it be possible to catch any type defined outside of these?

[brettz9]

Good finds... Another allowable case is with generics; see https://github.com/google/closure-compiler/wiki/Generic-Types#multiple-template-types (with jsdoc explicitly supporting all Closure types and TypeScript adopting generics as well).

But yes, this seems too permissive. I've filed jsdoctypeparser/jsdoctypeparser#99 since I think this should be disallowed at the type parser level. I'm therefore closing this issue here, but feel free to subscribe to that issue.

[binury]

Thanks!

…

On Oct 31, 2019, 19:58 -0500, Brett Zamir ***@***.***>, wrote: Good finds... Another allowable case is with generics; see https://github.com/google/closure-compiler/wiki/Generic-Types#multiple-template-types (with jsdoc explicitly supporting all Closure types and TypeScript adopting generics as well). But yes, this seems too permissive. I've filed jsdoctypeparser/jsdoctypeparser#99 since I think this should be disallowed at the type parser level. I'm therefore closing this issue here, but feel free to subscribe to that issue. — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub, or unsubscribe.