Skip to content

chore: fix generateRule #1004

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brettz9 merged 1 commit into from
Mar 22, 2023
Merged

chore: fix generateRule #1004

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions src/bin/generateRule.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
* @example
*
* ```shell
* npm run create-rule my-new-rule --recommended
* npm run create-rule my-new-rule -- --recommended
* ```
*/

Expand Down Expand Up @@ -217,8 +217,8 @@ export default iterateJsdoc(({

await replaceInOrder({
checkName: 'index recommended',
newLine: `${' '.repeat(8)}'jsdoc/${ruleName}': '${recommended ? 'warn' : 'off'}',`,
oldRegex: /\n\s{8}'jsdoc\/(?<oldRule>[^']*)': '[^']*',/gu,
newLine: `${' '.repeat(6)}'jsdoc/${ruleName}': ${recommended ? 'warnOrError' : '\'off\''},`,
oldRegex: /\n\s{6}'jsdoc\/(?<oldRule>[^']*)': .*?,/gu,
path: './src/index.js',
});

Expand Down
10 changes: 6 additions & 4 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -172,10 +172,12 @@ const createRecommendedTypeScriptRuleset = (warnOrError) => {
...ruleset,
rules: {
...ruleset.rules,
'jsdoc/no-types': warnOrError,
'jsdoc/require-param-type': 'off',
'jsdoc/require-property-type': 'off',
'jsdoc/require-returns-type': 'off',
/* eslint-disable indent -- Extra indent to avoid use by auto-rule-editing */
'jsdoc/no-types': warnOrError,
'jsdoc/require-param-type': 'off',
'jsdoc/require-property-type': 'off',
'jsdoc/require-returns-type': 'off',
/* eslint-enable indent */
},
};
};
Expand Down