Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not send 500 on shutdown #12

Closed
florianmutter opened this issue Jul 23, 2019 · 2 comments
Closed

Do not send 500 on shutdown #12

florianmutter opened this issue Jul 23, 2019 · 2 comments
Labels
enhancement New feature or request released

Comments

@florianmutter
Copy link

According to https://freecontent.manning.com/handling-client-requests-properly-with-kubernetes/ it is not necessary to send 500 on shutdown. I think it should be avoided to have more meaning full event logs of the pods. Otherwise each shutdown generates logs of failed readiness requests
@gajus gajus added the enhancement New feature or request label Jul 23, 2019
@gajus gajus closed this as completed in a430348 Jul 23, 2019
@gajus
Copy link
Owner

gajus commented Jul 23, 2019

🎉 This issue has been resolved in version 4.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@gajus gajus added the released label Jul 23, 2019
gajus added a commit that referenced this issue Jul 23, 2019
@gajus
docs: add a delay before stop handling incoming requests (#12)
a0f74af
@gajus
Copy link
Owner

gajus commented Jul 23, 2019

Added a note to the README.md referencing the article.

@gajus gajus mentioned this issue Oct 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gajus @florianmutter