Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove the repo repair feature from the codebase #2929

Open
martenson opened this issue Sep 16, 2016 · 6 comments

Comments

Projects
None yet
3 participants
@martenson
Copy link
Member

commented Sep 16, 2016

based on the comment from @mvdbeek

When in trouble the repo re-installation is the recommended path, I believe 'repair' covers some subset of these cases but in the end behaves like blackbox that admins (and me) don't understand.

Benefits: simplification of repo maintenance; remove code, reduce complexity

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

We should probably replace repair with re-install, to minimize the amount of frustrating click and wait and click (and wait ...). Re-install should be a light-weight function that sequentially calls uninstall and then install. Does that make sense?

@bgruening

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

I think the point of repair was to recursively traverse the dependency tree, a single reinstall button can not "replace" this.
ping @gregvonkuster

@martenson

This comment has been minimized.

Copy link
Member Author

commented Sep 16, 2016

@mvdbeek implementing reinstall button makes great sense now when we have hot reload

@mvdbeek

This comment has been minimized.

Copy link
Member

commented Sep 16, 2016

I think the point of repair was to recursively traverse the dependency tree, a single reinstall button can not "replace" this.

Hmm, that may be a show-stopper for TS packages, you're right. Though I wonder if you're not ultimately better off uninstalling the packages that don't work followed by reinstalling the tool?

@bgruening

This comment has been minimized.

Copy link
Member

commented Sep 17, 2016

I also use it rarely, maybe in 6 month when conda is established?

@martenson

This comment has been minimized.

Copy link
Member Author

commented Feb 14, 2017

@bgruening do we need this feature given we have Conda?

recursively traverse the dependency tree

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.