Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrations broken on mysql #6401

Closed
mvdbeek opened this issue Jun 25, 2018 · 6 comments
Closed

Migrations broken on mysql #6401

mvdbeek opened this issue Jun 25, 2018 · 6 comments

Comments

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Jun 25, 2018

This is with a fresh mysql 5.7 installation and database:

https://gist.github.com/mvdbeek/ef980138db903a9a0ad617f2ac95b025

Some of them are harmless and referencing keys that we eliminated later on, but a couple newer ones seem problematic, like

https://gist.github.com/mvdbeek/ef980138db903a9a0ad617f2ac95b025#file-mysql_migration-txt-L536 sequencing request table, eliminated long ago

https://gist.github.com/mvdbeek/ef980138db903a9a0ad617f2ac95b025#file-mysql_migration-txt-L872 eliminated in migration 91

https://gist.github.com/mvdbeek/ef980138db903a9a0ad617f2ac95b025#file-mysql_migration-txt-L1241 -- probably breaks data manager job association table on mysql, solution is to change TEXT type to TrimmedString(255) for data_manager_id in DataManagerJobAssociation. Which we also do for the tool_id, so this feels like the right thing to do

https://gist.github.com/mvdbeek/ef980138db903a9a0ad617f2ac95b025#file-mysql_migration-txt-L1391 -- needs to be 64 chars long max, so workflow_invocation_step_output_dataset_collection_association_ibfk_1 is too long.

@FredericBGA
Copy link
Contributor

@FredericBGA FredericBGA commented Jun 26, 2018

https://gist.github.com/mvdbeek/ef980138db903a9a0ad617f2ac95b025#file-mysql_migration-txt-L1426
breaks workflow_invocation_step_output_dataset_collection_association which is not created in my database.
workflow_invocation_output_dataset_collection_association_ibfk_1 is too long

Loading

@mvdbeek
Copy link
Member Author

@mvdbeek mvdbeek commented Jun 26, 2018

Right, missed that one. Same issue as with workflow_invocation_step_output_dataset_collection_association_ibfk_1

Loading

@dannon
Copy link
Member

@dannon dannon commented Jun 26, 2018

Loading

@FredericBGA
Copy link
Contributor

@FredericBGA FredericBGA commented Jun 26, 2018

So, in order to do a simple test, how many tables do I will have at the end of migration ?
Right now:

mysql> show tables;
[...]
169 rows in set

Loading

@martenson
Copy link
Member

@martenson martenson commented Aug 1, 2019

xref #8400

Loading

@FredericBGA
Copy link
Contributor

@FredericBGA FredericBGA commented Aug 12, 2019

You can close this now.

Loading

@martenson martenson closed this Aug 12, 2019
nsoranzo added a commit to nsoranzo/galaxy that referenced this issue Aug 16, 2019
Fix galaxyproject#6401 .
Fix galaxyproject#8400 .

Remove `index=True` from some `Column()` definitions in
lib/galaxy/model/mapping.py when the index was not part of any migration.
nsoranzo added a commit to nsoranzo/galaxy that referenced this issue Aug 18, 2019
Fix galaxyproject#6401 .
Fix galaxyproject#8400 .

Remove `index=True` from some `Column()` definitions in
lib/galaxy/model/mapping.py when the index was not part of any migration.
HadleyKing added a commit to biocompute-objects/galaxy that referenced this issue Oct 30, 2019
Fix galaxyproject#6401 .
Fix galaxyproject#8400 .

Remove `index=True` from some `Column()` definitions in
lib/galaxy/model/mapping.py when the index was not part of any migration.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

4 participants