Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't create job output datasets on disk in web threads #6513

Closed
jmchilton opened this issue Jul 18, 2018 · 0 comments

Comments

Projects
None yet
1 participant
@jmchilton
Copy link
Member

commented Jul 18, 2018

The job setup code in the job handler should be doing the makedirs and stuff but it appears to happen in job creation code in response to tool form submission. This means a slower user experience and also means disk slow downs could prevent jobs from being created and hinder user experience even further and probably hang web threads as well. After #6373 is merged, this functionality is called from ObjectStorePopulator.create_datasets() in galaxy.tools.actions but it really needs to be moved to the job handler I think (#6373 doesn't make this worse - it actually separates things out a little better and hopefully will allow us to improve this more easily).

xref #4959

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.