Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

workflow editor: unzip collection can not connect to downstream tools #7930

Closed
bernt-matthias opened this issue May 10, 2019 · 4 comments
Closed
Assignees

Comments

@bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented May 10, 2019

In this example workflow I would like to connect the outputs of Unzip collection to a tool that accepts data sets and collections (via <param type="data" multiple="true"/>). But this seems to be impossible.

https://usegalaxy.eu/u/maze/w/unnamed-workflow

Odd thing is that if I export this from a history a connection is created:

https://usegalaxy.eu/u/maze/w/workflow-constructed-from-history-unnamed-history

I have the same on our 19.01 instance and dev instance. There I also had the impression that export and import via a file removes the connection again. But I need to verify this.

@bernt-matthias
Copy link
Contributor Author

@bernt-matthias bernt-matthias commented May 28, 2019

Just checked with the new feature to show the reason for not connecting. There are two messages:

  • "Effective output data type(s) [data] do not appear to match input type(s)...."
  • Can't map over this input with output collection type - an output of this tool is not mapped over constraining this input. Disconnect output(s) and try again."

The former is quite clear and appears for tools created new in the editor. The latter is cryptic to me and appears for the downstream tool created during the extraction from history.

Loading

@jennaj
Copy link
Member

@jennaj jennaj commented May 28, 2019

The usual path is to un-connect all noodles then reconnect them starting from the inputs > downstream steps. This resets the workflow internal metadata.

Two related tickets (and more linked from them). Think most of what can be done, has been done. But maybe the message could be improved/clarified?

This part is confusing. Translates into the action of "disconnecting downstream noodles then reconnecting, starting from the input" eg left-to-right.

Disconnect output(s) and try again

This part seems too technical:

Can't map over this input with output collection type - an output of this tool is not mapped over constraining this input.

#5632
#7431

ping @jmchilton @mvdbeek @dannon

I could help rewrite these, and others that are new messages in WF help. Where would I look to view all of them?

Loading

@bernt-matthias
Copy link
Contributor Author

@bernt-matthias bernt-matthias commented May 28, 2019

Loading

@jennaj jennaj self-assigned this Jun 5, 2019
@jennaj
Copy link
Member

@jennaj jennaj commented Sep 15, 2020

@bernt-matthias I am going to close this out but we can reopen if needed.

The goal is to reset the workflow's metadata. To do that, reconnecting noddles input > output is still required afaik if that is all you have, for any changes that present with a metadata conflict in the editor (and prior types of workflow failures -- addressed now). Or, exporting a fresh workflow from history will work as you found. I don't think that generating a workflow share link, copying, then pasting that back into Galaxy will reset the metadata (it does create a new copy) but that is something to try.

cc @jmchilton

Loading

@jennaj jennaj closed this Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
2 participants