Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"logout" generates an incorrect redirect URL when deployed behind Apache or Ngnix #9270

Closed
jennaj opened this issue Jan 27, 2020 · 6 comments
Closed

Comments

@jennaj
Copy link
Member

@jennaj jennaj commented Jan 27, 2020

See discussion here: https://help.galaxyproject.org/t/apache-redirect-at-logout/2830

It seems to be at least as old as 19.05 and still present in 19.09.

Bug or a configuration problem?

@jennaj jennaj added the triage label Jan 27, 2020
@bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Jan 30, 2020

Note: same for nginx.

In my case the the login is actually sucessful .. despite that the login page is shown. So already after the first login one can for instance click on "Analyze data" and start to work.

Loading

@jennaj jennaj changed the title "logout" generates an incorrect redirect URL when deployed behind Apache "logout" generates an incorrect redirect URL when deployed behind Apache or Ngnix Jan 31, 2020
@jennaj
Copy link
Member Author

@jennaj jennaj commented Jan 31, 2020

@bernt-matthias Thanks for clarifying scope/behavior!

That a user is actually logged in but is presented with a login form seems worse. The GUI should be very clear about login status for as many use cases as possible, yes?

Hypothetical scenario: Someone tries to log in, gets that page, doesn't realize is actually logged in, walks away for whatever reason from a shared computer/workstation or desk/own computer, and then someone else could access that account. Not so great for anyone, but if that account is an admin account...

@dannon @natefoo others ... Thoughts?

Loading

@RJMW
Copy link
Contributor

@RJMW RJMW commented Mar 4, 2020

We are experiencing the same issue (19.09)

Loading

@cche
Copy link
Contributor

@cche cche commented Mar 12, 2020

I'm experiencing the same on two local galaxy instances. We have had the same behavior on versions 19.05 to 20.01.

On the first instance we login after the second try. This server is behind nginx on the same machine.

The other instance is worse in that the login screen appears recursively and we never get a successful login. If I type the /login path and put my credentials in the login screen and hit enter I have to login a second time to get the menu show the admin entry. Then I can use all menus except for 'Analyze data' which throws me out again. I get access to the histories by going to the admin -> Users and impersonate myself.
This server is behind apache on a different machine.

I have a screen recording if it can help to clarify.

An aside note, the double login started exactly after having an error message after impersonating one of my users. The same thing for the second admin of the Galaxy instance. I can not tell if it is the cause or just a symptom.
Second note, I have the impression that this appeared gradually. At first double login, then recursive login screen for me, followed some time after by the second admin of Galaxy. Now some users are suffering the same. I can not tell if the users have been active the whole time so maybe they just see it now because they did not login for some time.

Please tell me if I can do anything to help.

Loading

@bernt-matthias
Copy link
Contributor

@bernt-matthias bernt-matthias commented Mar 12, 2020

Discussion on the dev gitter channel indicates that this is solved on 20.01 - I was able to verify on dev. Anyone planning to upgrade to 19.09 in the next time?

@cche The problems on your 20.01 instance might be due to the apache config.

Loading

@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Mar 18, 2021

Thanks @bernt-matthias @cche, sounds like it's resolved then.

Loading

@mvdbeek mvdbeek closed this Mar 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
5 participants