[20.09] Fix Workflow node input terminal not updating #10626
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes a silent error when hitting `this.outputTerminals[name].$el.remove();` This seems to not be necessary, but it is super weird that there is no error logged. I just found it by stepping through this line by line in the debugger. This fixes galaxyproject#10622
jmchilton
approved these changes
Nov 5, 2020
guerler
approved these changes
Nov 5, 2020
guerler
merged commit 844c4e5
into
galaxyproject:release_20.09
15 of 19 checks passed
|
@mvdbeek Thank you for fixing this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
when a new input is selected.
This is easier to describe with a gif:
Fixes #10622
The text was updated successfully, but these errors were encountered: