Implement read-only conda resolver. #10810
Conversation
|
Can you also add a note to https://github.com/galaxyproject/galaxy/blob/dev/doc/source/admin/dependency_resolvers.rst#conda-dependency-resolver about this ? |
jmchilton
force-pushed
the
conda_readonly
branch
from
b9cfbda
to
33f3d46
Compare
| @@ -240,9 +241,16 @@ class InstallableDependencyResolver(metaclass=ABCMeta): | |||
| """ Mix this into a ``DependencyResolver`` and implement to indicate | |||
| the dependency resolver can attempt to install new dependencies. | |||
| """ | |||
| read_only = False | |||
There was a problem hiding this comment.
Given that the presence of the install_dependency method or inheriting from InstallableDependencyResolver is not going to be a reliable indication of the resolver's ability to install dependencies any more, I suggest to merge this class into DependencyResolver.
Also, these following 2 lines need to be updated any way to check for read_only instead of using hasattr:
https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/tool_util/deps/views.py#L147 (resolver.disabled should probably also checked here, raising a different exception)
https://github.com/galaxyproject/galaxy/blob/dev/lib/galaxy/tool_util/deps/views.py#L201
|
Pushing this because of the outstanding comment |
jmchilton
force-pushed
the
conda_readonly
branch
from
08fe90e
to
22aa23e
Compare
|
I continue to prefer this version, but I have addressed the comment with a separate implementation in #10822. I've rebased both versions and attempted to fix the test error in the other version. |
No description provided.