Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move docstring linting to GitHub workflows #11300

Merged
merged 3 commits into from
Feb 5, 2021

Conversation

nsoranzo
Copy link
Member

@nsoranzo nsoranzo commented Feb 4, 2021

Also:

  • Fix pip cache key.
  • Quote Python versions in YAML. Treating them as floats will break with Python 3.10 .

Treating them as floats will break with Python 3.10 .
which sometimes removes manually added labels.
@nsoranzo nsoranzo closed this Feb 4, 2021
@nsoranzo nsoranzo reopened this Feb 4, 2021
@@ -10,6 +10,11 @@ jobs:
env:
MILESTONE_NUMBER: 19
steps:
- name: Debug
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In case any one is wondering, I have been trying to understand why sometimes the bot removes manually-added labels, but I couldn't reproduce it reliably on my fork. So it's not a debugging leftover, I'd like to have these lines in for when it reappears.

@mvdbeek mvdbeek merged commit 5196a26 into galaxyproject:dev Feb 5, 2021
@mvdbeek
Copy link
Member

mvdbeek commented Feb 5, 2021

Thank you @nsoranzo!

@nsoranzo nsoranzo deleted the docstring_lint_gh_wf branch February 5, 2021 16:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants