adding nameSuggestion to PairCollectionCreator #11489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…used bits of code that I noticed
|
Try to move lcs code into mixin - thanks! |
jmchilton
approved these changes
Mar 19, 2021
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why you made the changes (e.g. references to GitHub issues being fixed).
Fix for #11249
A description of the implementation of the changes.
Added (and modified) guessNameForPair method to PairCollectionCreator
How to test the changes, if you haven't included specific tests already.
Try to create a pair with two datasets, see that the pair name is automatically generated for you. You can still edit it, if you want.