Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise late validation of tool parameters #115

Merged
merged 12 commits into from Apr 16, 2015

Conversation

@guerler
Copy link
Contributor

guerler commented Apr 14, 2015

This PR brings the late validation back into the local scope of a particular tool parameter class. Additionally it replaces the late validation condition caller with a single, generic condition which validates if options are available. This is more rigorous and comes with benefits: 1. The front-end is now in sync and knows which parameters are late validated in the backend. 2. The workflow editor is able to resolve dynamic parameters unless they depend on missing input datasets. 3. It overall simplifies the parameter handling.

@guerler

This comment has been minimized.

Copy link
Contributor Author

guerler commented Apr 14, 2015

Adjusted test cases will be available later today.

@carlfeberhard

This comment has been minimized.

Copy link
Contributor

carlfeberhard commented Apr 16, 2015

+1

1 similar comment
@dannon

This comment has been minimized.

Copy link
Member

dannon commented Apr 16, 2015

+1

dannon added a commit that referenced this pull request Apr 16, 2015
Revise late validation of tool parameters
@dannon dannon merged commit 1f90dfd into galaxyproject:dev Apr 16, 2015
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
@guerler guerler deleted the guerler:revise_validation branch May 18, 2015
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.