Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[21.01] Change Upload button tooltip position #11634

Merged
merged 1 commit into from
Mar 16, 2021
Merged

[21.01] Change Upload button tooltip position #11634

merged 1 commit into from
Mar 16, 2021

Conversation

OlegZharkov
Copy link
Contributor

What did you do?

Moved Upload button tooltip to the bottom

Why did you make this change?

Auto position doesn't seem to work as expected
image

How to test the changes?

  • Instructions for manual testing are as follows:
    1. Move the mouse over the upload button

For UI Components

  • I've included a screenshot of the changes
    image

ping @mvdbeek

@OlegZharkov OlegZharkov changed the base branch from dev to release_21.01 March 16, 2021 13:30
@github-actions github-actions bot added this to the 21.05 milestone Mar 16, 2021
@OlegZharkov OlegZharkov changed the title Change Upload button tooltip position [21.01] Change Upload button tooltip position Mar 16, 2021
@dannon dannon merged commit 185e720 into galaxyproject:release_21.01 Mar 16, 2021
@github-actions
Copy link

This PR was merged without a "kind/" label, please correct.

@OlegZharkov OlegZharkov deleted the upload-btn-tooltip branch March 16, 2021 13:48
@OlegZharkov
Copy link
Contributor Author

thanks @dannon

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dannon dannon dannon approved these changes

Assignees
No one assigned
Labels
area/UI-UX kind/bug
Projects
None yet
Milestone
21.05
Development

Successfully merging this pull request may close these issues.
2 participants
@OlegZharkov @dannon