galaxyproject / galaxy Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Collection edit interface that allows changing datatype and dbkey #11799
Merged
mvdbeek
merged 119 commits into
galaxyproject:dev
from
assuntad23:feature/6965/change-datatype-and-dbkey
Sep 16, 2021
Merged
Create Collection edit interface that allows changing datatype and dbkey #11799
mvdbeek
merged 119 commits into
galaxyproject:dev
from
assuntad23:feature/6965/change-datatype-and-dbkey
Sep 16, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ature/6965/change-datatype-and-dbkey
…ature/6965/change-datatype-and-dbkey
…ature/6965/change-datatype-and-dbkey
…rs, getting a 200, but setting incorrect id
…ature/6965/change-datatype-and-dbkey
…ature/6965/change-datatype-and-dbkey
…ature/6965/change-datatype-and-dbkey
…or explicit history_ids
dannon
reviewed
Sep 15, 2021
client/src/components/Collections/common/CollectionEditView.vue
Outdated
Show resolved
Hide resolved
dannon
approved these changes
Sep 15, 2021
mvdbeek
reviewed
Sep 15, 2021
mvdbeek
reviewed
Sep 15, 2021
| encoded_id = int(trans.app.security.decode_id(input_id)) | ||
| decoded_id = self.hda_manager.get_accessible(encoded_id, trans.user).history_id | ||
| target_history = self.history_manager.get_owned(decoded_id, trans.user, current_history=trans.history) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Suggested change
| encoded_id = int(trans.app.security.decode_id(input_id)) | |
| decoded_id = self.hda_manager.get_accessible(encoded_id, trans.user).history_id | |
| target_history = self.history_manager.get_owned(decoded_id, trans.user, current_history=trans.history) | |
| decoded_id = trans.app.security.decode_id(input_id) | |
| target_history = self.hda_manager.get_accessible(encoded_id, trans.user).history | |
| self.history_manager.error_unless_owner(target_history, trans.user, current_history=trans.history) |
This seems a little cleaner ?
…s.py Co-authored-by: Marius van den Beek <m.vandenbeek@gmail.com>
Co-authored-by: Dannon <dannon.baker@gmail.com>
|
Thanks a lot @assuntad23! |
|
This PR was merged without a "kind/" label, please correct. |
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
What did you do?
Why did you make this change?
#6965
How to test the changes?
(select the most appropriate option; if the latter, provide steps for testing below)
For the Database Tab:
For the Convert Tab:
License
For UI Components
simplescreenrecorder-2021-05-19_00.27.35.online-video-cutter.com.mp4
In the video above, you'll see:
The text was updated successfully, but these errors were encountered: