Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[21.01] Fix mulled singularity building #11979

Merged

Conversation

mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented May 14, 2021

What did you do?

  • Fix mulled singularity building

Why did you make this change?

This used to fail with

[May 13 12:53:06] DEBU Container [8a432293fb2f step-adb59c6b2d] started, waiting for completion
[May 13 12:53:06] SERR mkdir: missing operand
[May 13 12:53:06] SERR Try 'mkdir --help' for more information.
[May 13 12:53:06] ERRO Task processing failed: Unexpected exit code [1] of container [8a432293fb2f step-adb59c6b2d], container preserved

When using the sh -c entrypoint we need to concatenate arguments in .run as individual
commands. You can see the full error in https://github.com/BioContainers/multi-package-containers/pull/1713/checks?check_run_id=2575472382

Broke in mvdbeek@71a70ea

How to test the changes?

(select the most appropriate option; if the latter, provide steps for testing below)

License

For UI Components

  • I've included a screenshot of the changes

This used to fail with
```
[May 13 12:53:06] DEBU Container [8a432293fb2f step-adb59c6b2d] started, waiting for completion
[May 13 12:53:06] SERR mkdir: missing operand
[May 13 12:53:06] SERR Try 'mkdir --help' for more information.
[May 13 12:53:06] ERRO Task processing failed: Unexpected exit code [1] of container [8a432293fb2f step-adb59c6b2d], container preserved
```
Involucro interpretes comma-separated arguments in `.run` as individual
commands. You can see the full error in https://github.com/BioContainers/multi-package-containers/pull/1713/checks?check_run_id=2575472382

Broke in 71a70ea
@bgruening
Copy link
Member

Cool, thanks for the fix!

@nsoranzo nsoranzo merged commit 036a8eb into galaxyproject:release_21.01 May 15, 2021
@nsoranzo nsoranzo deleted the fix_mulled_build_singularity branch May 15, 2021 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants