Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make markdown components for reports and pages full width #12085

Merged
merged 1 commit into from Jun 1, 2021

Conversation

@hexylena
Copy link
Member

@hexylena hexylena commented Jun 1, 2021

This pull requests makes all components full width in the report interface. It fixes #11564 and the issues with content flowing weirdly because all of the boxes were float: left.

image of report with full width boxes

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. Make a workflow
    2. add a report
    3. run the workflow
    4. see that the report has full-width components

License

dannon
dannon approved these changes Jun 1, 2021
@jmchilton jmchilton requested a review from guerler Jun 1, 2021
@guerler guerler merged commit 7253dc8 into galaxyproject:dev Jun 1, 2021
30 checks passed
Loading
@mvdbeek
Copy link
Member

@mvdbeek mvdbeek commented Sep 14, 2021

Should we highlight this @hexylena ? @pcm32's report in #12455 (comment) should look really good now :)

Loading

@hexylena
Copy link
Member Author

@hexylena hexylena commented Sep 14, 2021

Yeah why not, it's a user facing thing that makes their life better. Good suggestion! :)

Loading

@hexylena hexylena deleted the make-report-components-full branch Sep 14, 2021
@mvdbeek mvdbeek changed the title Make components full width Make markdown components for reports and pages full width Nov 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

5 participants