Add "View Details" button for collections #12261
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
jmchilton
reviewed
Jul 15, 2021
client/src/components/History/ContentItem/DatasetCollection/DscMenu.vue
Outdated
Show resolved
Hide resolved
mvdbeek
force-pushed
the
view_collection_info_button
branch
4 times, most recently
from
fd20c03
to
57de747
|
Making good progress here: |
assuntad23
reviewed
Aug 18, 2021
client/src/components/History/ContentItem/DatasetCollection/DscMenu.vue
Outdated
Show resolved
Hide resolved
mvdbeek
force-pushed
the
view_collection_info_button
branch
3 times, most recently
from
4391d80
to
74ab0bb
Which loads up the JobDetails.vue component. This is super-useful for dynamic collections that failed, where you had no chance to see the stderr or stdout.
…et id in query params
I think this makes sense, and we can label the output with the `label` if it is available for an output.
Otherwhise the menu may flow out of the center iframe in the job outputs view.
mvdbeek
reviewed
Sep 7, 2021
jmchilton
approved these changes
Sep 8, 2021
dannon
approved these changes
Sep 9, 2021
|
This PR was merged without a "kind/" label, please correct. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Which loads up the JobDetails.vue component. This is super-useful for
dynamic collections that failed, where you had no chance to see the
stderr or stdout.
Currently only available in the new history panel.
How to test the changes?
(Select all options that apply)
License
The text was updated successfully, but these errors were encountered: