galaxyproject / galaxy Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement folder selection in file source upload modal #12310
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dynamically track current directory
A lot of fixes, namely reworked select all bahaviour, fix selecting subsubdirectory, fix root directory accidental selection, fix importing from different source with the same path ant etc
select all functionality test, directory mode test, finalize test additional refactor
jmchilton
approved these changes
Sep 8, 2021
|
@jennaj this one is for you. You raised this issue somewhere and I do not remember where :) |
mvdbeek
approved these changes
Sep 8, 2021
3 tasks
|
thanks for merging it! @jmchilton @mvdbeek |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
This PR brings lots of features in selecting rendered items on file source upload modal. It's possible now to select folders including all subfolders and corresponding files, also reworked
select allbutton and tracking of selected/unselected and mixed items (directory was partially selected).Since the logic has a lot of use-cases I included tests.
As a tiny bonus it also tests 'directory mode'.
Example:

P.S. writing tests was fun, while you write them you discover bugs that shouldn't be there and you go fix them
Depends on #12297 and #12307
How to test the changes?
(Select all options that apply)
License
The text was updated successfully, but these errors were encountered: