Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement folder selection in file source upload modal #12310

Merged
merged 29 commits into from Sep 8, 2021

Conversation

@OlegZharkov
Copy link
Member

@OlegZharkov OlegZharkov commented Jul 30, 2021

This PR brings lots of features in selecting rendered items on file source upload modal. It's possible now to select folders including all subfolders and corresponding files, also reworked select all button and tracking of selected/unselected and mixed items (directory was partially selected).

Since the logic has a lot of use-cases I included tests.
As a tiny bonus it also tests 'directory mode'.

Example:
Peek 2021-08-11 19-27

P.S. writing tests was fun, while you write them you discover bugs that shouldn't be there and you go fix them

Depends on #12297 and #12307

How to test the changes?

(Select all options that apply)

License

@OlegZharkov OlegZharkov changed the title select path in file source implement selecting a folder in file source (upload modal) Jul 30, 2021
@OlegZharkov OlegZharkov force-pushed the selectAllSubfolders branch from 9882c07 to 2bdf76a Aug 3, 2021
@OlegZharkov OlegZharkov force-pushed the selectAllSubfolders branch from fccd63c to 95bcdbf Aug 6, 2021
@OlegZharkov OlegZharkov force-pushed the selectAllSubfolders branch from 89a9b03 to 8946aba Aug 10, 2021
OlegZharkov added 4 commits Aug 11, 2021
select all functionality test, directory mode test, finalize test
additional refactor
@OlegZharkov OlegZharkov marked this pull request as ready for review Aug 11, 2021
@github-actions github-actions bot added this to the 21.09 milestone Aug 11, 2021
@bgruening
Copy link
Member

@bgruening bgruening commented Sep 8, 2021

@jennaj this one is for you. You raised this issue somewhere and I do not remember where :)

Loading

mvdbeek
mvdbeek approved these changes Sep 8, 2021
@mvdbeek mvdbeek merged commit a5cf27d into galaxyproject:dev Sep 8, 2021
32 of 33 checks passed
Loading
@OlegZharkov
Copy link
Member Author

@OlegZharkov OlegZharkov commented Sep 8, 2021

thanks for merging it! @jmchilton @mvdbeek

Loading

@mvdbeek mvdbeek changed the title implement selecting a folder in file source (upload modal) Implement folder selection in file source upload modal Oct 31, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked issues

Successfully merging this pull request may close these issues.

None yet

5 participants