Implement news webhook to handle release announcements

[hexylena]

This is based off of the version of the Galaxy server, and the version last seen by the user (as reported by localStorage.) When an admin upgrades their server, the users of that server will see a notification icon that will hopefully draw their eyes to seeing the new features in their version of Galaxy.

fixes the comment in #3950 (comment) I guess. There's a notification icon. And a pip! And then it gets 'marked read'. Whee.

Design Commentary

Discussed with @shiltemann the preferred icon, this bell seemed like a good choice because it would give us a place in the future to put notifications if we implement such a system. We could simply combine it into a multi-item news feed and it'd be fine for users.

I tested out a couple different icons, I wasn't super happy with any, but this seemed like it was OK + worked for the future.

For the pip, I thought about making it the active colour

Open Question

Should we do something about dev branch? Either opening the release notes early and updating them as we go along? Or just leave it?

I guess main users will see this as main updates before we publish our announcements? That really feels like motivation to make the release notes earlier and update them as we go along.

How to test the changes?

• Instructions for manual testing are as follows:
  1. Open Galaxy (well, not dev, a version before dev since the release notes page doesn't exist for that.)
  2. A notification icon appears in the masthead, along with a little 'pip' I think they're called
  3. Clicking on it opens the release notes for that version of galaxy, and removes the pip
  4. The pip stays removed (assuming one doesn't clear session/etc.)

License

• I agree to license these contributions under Galaxy's current license.
• I agree to allow the Galaxy committers to license these and all my past contributions to the core galaxy codebase under the MIT license. If this condition is an issue, uncheck and just let us know why with an e-mail to galaxy-committers@lists.galaxyproject.org.

[bgruening]

Very cool, related: https://docs.google.com/document/d/1EA6RBqaWNBYYOYcUSxDoPPNQ4GaGbZCDwWWinLTpQNg/edit?usp=sharing

Thanks @hexylena!

[hexylena]

Ahh would you want to add that to #2324 @bgruening? My 5 year old issue for that feature could use those nice new use cases.

Edit, you already commented that there.

[bgruening]

Edit, you already commented that there.

And I didn't know it anymore :)

[dannon]

This is nice. I think I'd really like the whole webhook icon (not just the pip) to disappear after use, though? What do folks think?

I'm a little worried about crowding the masthead with things folks use very sparingly.

[hexylena]

• I definitely wanted the "no news" state to be unintrusive, I'm likewise worried it's "noisy" for something that you want rarely.
• I worry that if it disappears, people who mis-click out of the release notes won't be able to find them again,
• This has the future outlook of mutating into the notification system, which is something we'd want to be persistent? (But that's a weak argument, that something might happen in the future, depending on when we can find someone.)

It's too bad we seem to be on an older fontawesome version, we could replace it with the outline version or so, to further de-emphasize it, in addition to removing the pip

[nsoranzo]

I'm a little worried about crowding the masthead with things folks use very sparingly.

• I worry that if it disappears, people who mis-click out of the release notes won't be able to find them again,

I also think it makes sense to have a place where to go back to old notifications once they are read, assuming the notification system is going to be used for more that just the release announcements.

[dannon]

* I definitely wanted the "no news" state to be unintrusive, I'm likewise worried it's "noisy" for something that you want rarely.

Yep, that's my main concern here.

* I worry that if it disappears, people who mis-click out of the release notes won't be able to find them again,

They're linked directly in the help section right next to this, so we could also add text at the top of the popup saying "You can always find the latest release notes ? Or just open in a new tab instead of iframe if that is really likely to be an issue where people can't find them?

It's too bad we seem to be on an older fontawesome version, we could replace it with the outline version or so, to further de-emphasize it, in addition to removing the pip

Our fontawesome supports this just fine, I'll follow up with a commit here.

[hexylena]

Oh, fantastic!!! I tried it with 'far' and didn't have success but maybe i tried adding the wrong classes. I think a new tab would be less ideal to my persepctive, I'd love to be able to keep people on galaxy and let them see a new feature in the release note, and immediately click into trying it out. Dannon ***@***.***> schrieb am Do., 2. Sept. 2021, 13:55:

…

* I definitely wanted the "no news" state to be unintrusive, I'm likewise worried it's "noisy" for something that you want rarely. Yep, that's my main concern here. * I worry that if it disappears, people who mis-click out of the release notes won't be able to find them again, They're linked directly in the help section right next to this, so we could also add text at the top of the popup saying "You can always find the latest release notes ? Or just open in a new tab instead of iframe if that is really likely to be an issue where people can't find them? It's too bad we seem to be on an older fontawesome version, we could replace it with the outline version or so, to further de-emphasize it, in addition to removing the pip Our fontawesome supports this just fine, I'll follow up with a commit here. — You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub <#12396 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AADP7O7CHL3RVIBNFGVHYDTT75QZ3ANCNFSM5DGSPI4A> . Triage notifications on the go with GitHub Mobile for iOS <https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675> or Android <https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.

[hexylena]

Ahh had to remove the fa class, ok, that's what I was missing!

And thanks for the reformat, I ran it through prettier cd client ; prettier --write ../path I figured it'd load the prettifer config in that folder since that was how the makefile looked, but maybe not

[dannon]

@hexylena Yeah, that's reasonable. I think it's personal preference -- I generally want everything in separate tabs and I find the popup frames more disorienting, but the idea of potentially clicking on a new feature in the release notes and having it pop up or something is pretty compelling.

Regarding the dev branch it should just show the same release that the release notes dropdown shows, so the previous 21.05 I think. which is also busted. We should probably target the previous release here, instead of a dead page in both places?

[hexylena]

We should probably target the previous release here, instead of a dead page in both places?

Any convenient way to get the 'previous release'? Or just checking for the 404 with a fetch you reckon?

That was part of my motivation for suggesting opening the release notes earlier, would nicely sidestep that :P

[hexylena]

how's hexylena@36782f9 sound @dannon

[dannon]

@hexylena It'll work for primary servers for release, want to add a 21.01 -> 21.09 for dev, then we've got a couple months?

[hexylena]

Smart

[dannon]

@hexylena Thanks, this is nice!