[21.05] Fix double enqueuing of upload jobs #12763
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvdbeek
force-pushed
the
fix_job_double_scheduling
branch
from
1ff980f
to
800b8d6
Compare
mvdbeek
force-pushed
the
fix_job_double_scheduling
branch
3 times, most recently
from
e1809af
to
76b7243
Compare
The canonical place to call enqueue is in https://github.com/galaxyproject/galaxy/blob/a5bb3e92667b96ef802b378f17788b253a5c0bc6/lib/galaxy/tools/execute.py#L127. In the process of enqueue the db-skip-locked assignment method will set the handler name to the default tag. If you do this more than once the job might be picked up by compatible handlers. Fixes galaxyproject#11335
mvdbeek
force-pushed
the
fix_job_double_scheduling
branch
from
76b7243
to
2a335c9
Compare
|
Thanks! I will merge this forward via PR, there will be conflicts. |
|
Even better, thanks! |
innovate-invent
pushed a commit
to brinkmanlab/galaxy-container
that referenced
this pull request
Oct 28, 2021
Was transaction isolation in an attempt to deal with galaxyproject/galaxy#12763
innovate-invent
pushed a commit
to brinkmanlab/galaxy-container
that referenced
this pull request
Oct 28, 2021
A bug caused job-handlers to automatically attach as workflow handlers. This was fixed in galaxyproject/galaxy#12763
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The canonical place to call enqueue is in
galaxy/lib/galaxy/tools/execute.py
Line 127 in a5bb3e9
In the process of enqueue the db-skip-locked assignment method will set
the handler name to the default tag. If you do this more than once the
job might be picked up by compatible handlers (more than once).
Fixes #11335
How to test the changes?
(Select all options that apply)
License