Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace backref with back_populates #13165

Merged
merged 1 commit into from Jan 14, 2022

Conversation

jdavcs
Copy link
Member

@jdavcs jdavcs commented Jan 13, 2022

Both do the job; however, using back_populates instead of backref has several advantages in the context of Galaxy's model, which is why all backref instances have been replaced with back_populates.

See #12064 for rationale (PR description: Notable issues >> back_populates vs. backref)

(Sorry I missed this in the initial review!)

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@jdavcs jdavcs added kind/refactoring cleanup or refactoring of existing code, no functional changes area/database Galaxy's database or data access layer labels Jan 13, 2022
@jdavcs jdavcs added this to the 22.01 milestone Jan 13, 2022
@jdavcs jdavcs requested a review from nuwang January 13, 2022 22:08
@mvdbeek mvdbeek modified the milestones: 22.01, 22.05 Jan 14, 2022
@mvdbeek mvdbeek merged commit 03ed4c6 into galaxyproject:dev Jan 14, 2022
@jdavcs jdavcs mentioned this pull request Jul 15, 2022
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/database Galaxy's database or data access layer kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants