Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Present unavailable options to logged-out users #14419

Merged
merged 9 commits into from Aug 10, 2022

Conversation

ElectronicBlueberry
Copy link
Member

@ElectronicBlueberry ElectronicBlueberry commented Aug 9, 2022

Relevant issues: #11372 #10418

This PR presents anonymous users (logged-out users) the options they would have when logging in / registering as disabled options, with a mouse-over prompt to log-in, in the History and Toolbox Panels.

This serves as an incentive to sign-up, acts as an additional indicator of being logged-out, and reduces confusion of why some options are missing.

image
image
image
image

This PR also reorders the history options panel.
The new order can be thought of in four sections:

  • Multiview
  • Job/Tool - Relevant Options (resume all, structure view)
  • File Operations (Copy, Delete, Export, ...)
  • Permission Options (Share, Permissions, Private)

image

I attempted to roughly order these sections by frequency of use, while maintaining blocks of available options when logged out, so the menu doesn't feel too scattered to anonymous users. Feedback is welcome.

This PR also standardizes the terminology of "log in"

How to test the changes?

(Select all options that apply)

  • I've included appropriate automated tests.
  • This is a refactoring of components with existing test coverage.
  • Instructions for manual testing are as follows:
    1. [add testing steps and prerequisites here if you didn't write automated tests covering all your changes]

License

@dannon
Copy link
Member

dannon commented Aug 9, 2022

I like this a lot. We probably need to standardize terminology here a bit though. I think 'login' works as a noun or adjective, but not as a verb, where it should be 'log in'. So "Log in to view favorites", instead of "Login to view favorites", etc.

Might be a couple other places already in the app to fix, too, like:
image

@ElectronicBlueberry
Copy link
Member Author

@dannon I renamed all verb occurrences of "login" I could find to "log in"

@nsoranzo nsoranzo changed the title Present unavalible Options to Logged-Out Users Present unavailable options to logged-out users Aug 10, 2022
@ElectronicBlueberry ElectronicBlueberry marked this pull request as ready for review August 10, 2022 10:11
@github-actions github-actions bot added this to the 22.09 milestone Aug 10, 2022
Copy link
Member

@dannon dannon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@davelopez
Copy link
Contributor

Thank you @ElectronicBlueberry it looks great!

(The failing tests are unrelated)

@davelopez davelopez merged commit a37658a into galaxyproject:dev Aug 10, 2022
@ElectronicBlueberry ElectronicBlueberry deleted the logged-out-users branch August 11, 2022 07:44
@hexylena hexylena added the highlight Included in user-facing release notes at the top label Feb 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/UI-UX highlight Included in user-facing release notes at the top kind/enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants