New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Present unavailable options to logged-out users #14419
Merged
davelopez
merged 9 commits into
galaxyproject:dev
from
ElectronicBlueberry:logged-out-users
Aug 10, 2022
Merged
Present unavailable options to logged-out users #14419
davelopez
merged 9 commits into
galaxyproject:dev
from
ElectronicBlueberry:logged-out-users
Aug 10, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ElectronicBlueberry
force-pushed
the
logged-out-users
branch
from
August 10, 2022 07:20
d9e2218
to
265e590
Compare
add assert_disabled to SmartComponent
ElectronicBlueberry
force-pushed
the
logged-out-users
branch
from
August 10, 2022 08:56
8b7a5d3
to
37a8de7
Compare
@dannon I renamed all verb occurrences of "login" I could find to "log in" |
nsoranzo
changed the title
Present unavalible Options to Logged-Out Users
Present unavailable options to logged-out users
Aug 10, 2022
dannon
approved these changes
Aug 10, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Thank you @ElectronicBlueberry it looks great! (The failing tests are unrelated) |
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant issues: #11372 #10418
This PR presents anonymous users (logged-out users) the options they would have when logging in / registering as disabled options, with a mouse-over prompt to log-in, in the History and Toolbox Panels.
This serves as an incentive to sign-up, acts as an additional indicator of being logged-out, and reduces confusion of why some options are missing.
This PR also reorders the history options panel.
The new order can be thought of in four sections:
I attempted to roughly order these sections by frequency of use, while maintaining blocks of available options when logged out, so the menu doesn't feel too scattered to anonymous users. Feedback is welcome.
This PR also standardizes the terminology of "log in"
How to test the changes?
(Select all options that apply)
License