Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scratchbook tour #1463

Merged
merged 5 commits into from Jan 14, 2016
Merged

Scratchbook tour #1463

merged 5 commits into from Jan 14, 2016

Conversation

@guerler
Copy link
Contributor

guerler commented Jan 9, 2016

This PR adds a Scratchbook tour, and identifiers for tool parameters and the upload settings popup. It also contains minor refactoring. The previously displayed todo list has been moved to #1423.

@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Jan 9, 2016

Awesome! I could use some of the new ID's also in my tour :)
I guess this is documentation and should target 16.01.

@guerler you can drag and drop in tours. You can upload data during a tour and you can drag and drop scratchbook windows around.

@martenson

This comment has been minimized.

Copy link
Member

martenson commented Jan 9, 2016

@bgruening This looks like a refactoring to me, it is probably fine to put it in 16.01 during freeze but I wouldn't start a habit of circumventing our own rules.

@guerler scratchbook tour hype! 💯

@guerler

This comment has been minimized.

Copy link
Contributor Author

guerler commented Jan 11, 2016

I agree with @martenson. I was not considering to place the tour into 16.01 unless people are in favor since it is not a bug fix and there are a few more things on the todo list.

@guerler guerler force-pushed the guerler:tour_000 branch 6 times, most recently from 7045a33 to dc20e26 Jan 11, 2016
@guerler guerler removed the status/WIP label Jan 12, 2016
@guerler guerler force-pushed the guerler:tour_000 branch 2 times, most recently from 88d1884 to c7d4999 Jan 13, 2016
@guerler guerler force-pushed the guerler:tour_000 branch from c7d4999 to 1a359a5 Jan 13, 2016
@hexylena hexylena removed the triage label Jan 13, 2016
@guerler guerler force-pushed the guerler:tour_000 branch from d495db1 to d11ab28 Jan 14, 2016
@guerler guerler force-pushed the guerler:tour_000 branch 2 times, most recently from 8c47f7a to e52626b Jan 14, 2016
@dannon

This comment has been minimized.

Copy link
Member

dannon commented Jan 14, 2016

Reveals a bug in the tour resuming approach: https://www.dropbox.com/s/sfle2ohydj5xmhf/Screenshot%202016-01-14%2009.35.59.png?dl=0

This contribution is solid though, merging, nice work Sam!

dannon added a commit that referenced this pull request Jan 14, 2016
Scratchbook tour
@dannon dannon merged commit be7c0df into galaxyproject:dev Jan 14, 2016
0 of 4 checks passed
0 of 4 checks passed
continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Test scheduled.
Details
framework test Test scheduled.
Details
toolshed test Test started.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
6 participants
You can’t perform that action at this time.