Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve dbkey handling for discovered datasets. #1610

Merged
merged 1 commit into from Feb 19, 2016

Conversation

jmchilton
Copy link
Member

Newer style <discover_datasets>'s based discovery will default to using an input dbkey the way normal inputs do. Legacy, implicit filename based discovery will continue to use '?' as the default.

This should work for collections and individual extra outputs.

Fixes #1598.

Thanks to @gregvonkuster for finding this issue and documenting it so thoroughly.

@jmchilton
Copy link
Member Author

Independent confirmation from Greg that this fixes the issue - #1598 (comment).

Newer style <discover_datasets>'s based discovery will default to using input_dbkey the way normal inputs do. Legacy, implicit filename based discovery will continue to use '?' as the default.

This should work for collections and individual extra outputs.

Fixes galaxyproject#1598.

Thanks to @gregvonkuster for finding this issue and documenting it so thoroughly.
@jmchilton
Copy link
Member Author

Rebased due to merge conflict (previously 4/4 were testing).

@guerler guerler self-assigned this Feb 17, 2016
@guerler
Copy link
Contributor

guerler commented Feb 17, 2016

👍

@guerler guerler removed their assignment Feb 17, 2016
martenson added a commit that referenced this pull request Feb 19, 2016
Improve dbkey handling for discovered datasets.
@martenson martenson merged commit d7eb315 into galaxyproject:dev Feb 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants