Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

various libraries refactoring and bugfixes #1751

Merged
merged 10 commits into from Feb 19, 2016

Conversation

martenson
Copy link
Member

please see the commit messages

modify_item_role_list = [ modify_role.name for modify_role in modify_roles ]
access_dataset_role_list = [ ( access_role.name, trans.security.encode_id( access_role.id ) ) for access_role in access_roles ]
manage_dataset_role_list = [ ( manage_role.name, trans.security.encode_id( manage_role.id ) ) for manage_role in manage_roles ]
modify_item_role_list = [ ( modify_role.name, trans.security.encode_id( modify_role.id ) ) for modify_role in modify_roles ]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this will change the output of the following API calls:

  • GET /api/libraries/datasets/{encoded_dataset_id}/permissions
  • POST /api/libraries/datasets/{encoded_dataset_id}/permissions

They are not available through BioBlend yet, but this should probably be highlighted in the Release Notes.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

that is correct, the endpoint's outputs (but also inputs) are changed :/

:param action: (required) describes what action should be performed
available actions: make_private, remove_restrictions, set_permissions
:type action: string
:param access_ids[]: list of Role.id defining roles that should have access permission on the dataset
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nsoranzo this now accepts encoded Role.id instead of Role.name thus changing the endpoint signature considerably :/

@martenson
Copy link
Member Author

this is now ready for review

@martenson martenson added kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes labels Feb 19, 2016
@jmchilton
Copy link
Member

👍

carlfeberhard added a commit that referenced this pull request Feb 19, 2016
various libraries refactoring and bugfixes
@carlfeberhard carlfeberhard merged commit 040fb81 into galaxyproject:dev Feb 19, 2016
@martenson martenson added this to the 16.04 milestone Apr 11, 2016
@martenson martenson deleted the libraries-refactor branch August 8, 2016 16:20
@galaxyproject galaxyproject deleted a comment from galaxybot Aug 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/API area/UI-UX kind/bug kind/refactoring cleanup or refactoring of existing code, no functional changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants