New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
various libraries refactoring and bugfixes #1751
various libraries refactoring and bugfixes #1751
Conversation
broken because of a change in the Galaxy modal object
minor stylistic fix for column width
fix a bug in making dataset private (when you called it multiple times it would always add a new datasetpermission) various refactorings of JS and py
modify_item_role_list = [ modify_role.name for modify_role in modify_roles ] | ||
access_dataset_role_list = [ ( access_role.name, trans.security.encode_id( access_role.id ) ) for access_role in access_roles ] | ||
manage_dataset_role_list = [ ( manage_role.name, trans.security.encode_id( manage_role.id ) ) for manage_role in manage_roles ] | ||
modify_item_role_list = [ ( modify_role.name, trans.security.encode_id( modify_role.id ) ) for modify_role in modify_roles ] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this will change the output of the following API calls:
- GET /api/libraries/datasets/{encoded_dataset_id}/permissions
- POST /api/libraries/datasets/{encoded_dataset_id}/permissions
They are not available through BioBlend yet, but this should probably be highlighted in the Release Notes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
that is correct, the endpoint's outputs (but also inputs) are changed :/
:param action: (required) describes what action should be performed | ||
available actions: make_private, remove_restrictions, set_permissions | ||
:type action: string | ||
:param access_ids[]: list of Role.id defining roles that should have access permission on the dataset |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nsoranzo this now accepts encoded Role.id instead of Role.name thus changing the endpoint signature considerably :/
this is now ready for review |
👍 |
various libraries refactoring and bugfixes
please see the commit messages