Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cli runner: use embed_metadata_in_job parameter #2107

Merged
merged 7 commits into from Apr 8, 2016

Conversation

@ThomasWollmann
Copy link
Contributor

ThomasWollmann commented Apr 8, 2016

Added code for reading the DEFAULT_EMBED_METADATA_IN_JOB parameter in jobs/runners/cli.py job submission.

@ThomasWollmann ThomasWollmann changed the title Master Fix cli runner: use DEFAULT_EMBED_METADATA_IN_JOB parameter Apr 8, 2016
@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Apr 8, 2016

@ThomasWollmann Can you please fix the errors reported in https://travis-ci.org/galaxyproject/galaxy/jobs/121647820 ? Thanks!

@ThomasWollmann

This comment has been minimized.

Copy link
Contributor Author

ThomasWollmann commented Apr 8, 2016

Related to: #1894

return
include_metadata = asbool( job_wrapper.job_destination.params.get( "embed_metadata_in_job", DEFAULT_EMBED_METADATA_IN_JOB ) )
if not self.prepare_job( job_wrapper, include_metadata=include_metadata):
return

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Apr 8, 2016

Member

Here return is indented with 5 chars with respect to the line above, should be 4.

@nsoranzo nsoranzo added the area/jobs label Apr 8, 2016
@ThomasWollmann ThomasWollmann changed the title Fix cli runner: use DEFAULT_EMBED_METADATA_IN_JOB parameter Fix cli runner: use embed_metadata_in_job parameter Apr 8, 2016
@nsoranzo

This comment has been minimized.

Copy link
Member

nsoranzo commented Apr 8, 2016

@galaxybot test this

@jmchilton

This comment has been minimized.

Copy link
Member

jmchilton commented Apr 8, 2016

Wonderful - thanks a million for the fix/enhancement.

@jmchilton jmchilton merged commit 4095336 into galaxyproject:dev Apr 8, 2016
4 checks passed
4 checks passed
api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
@bgruening

This comment has been minimized.

Copy link
Member

bgruening commented Apr 8, 2016

Awesome! Thanks @ThomasWollmann! Hope you enjoyed the Workshop!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants
You can’t perform that action at this time.