Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor checking tool files toward reuse with workflows in planemo. #2183

Merged
merged 1 commit into from Apr 18, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented Apr 18, 2016

Improve docstrings, import order, and interface definiton in that file as well.

@@ -156,11 +171,19 @@ def looks_like_a_tool_cwl(path):
return False

file_class = as_dict.get("class", None)
if classes is None or file_class not in classes:
return False

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo Apr 18, 2016

Member

Is there a use-case for calling looks_like_a_cwl_artifact(path, None) ?

is_a_yaml_with_class() has no default value for classes.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Apr 18, 2016

Author Member

I think instead of:

    if classes is None or file_class not in classes:
        return None

I probably meant

    if classes is not None and file_class not in classes:
        return None

that way if no classes are chosen as filters, it would work for any class - still potentially a useful operation.

This comment has been minimized.

Copy link
@jmchilton

jmchilton Apr 18, 2016

Author Member

I've updated the PR with this change.

Refactor checking tool files toward reuse with workflow in planemo.
Improve docstrings, import order, and interface definiton in that file as well.

Updated with improved conditional pass through ``looks_like_a_cwl_artifact`` as spotted by @nsoranzo.

@jmchilton jmchilton changed the title Refactor checking tool files toward reuse with workflow in planemo. Refactor checking tool files toward reuse with workflows in planemo. Apr 18, 2016

@jmchilton jmchilton force-pushed the jmchilton:more_looks_like_tool branch from 80fdf10 to f505041 Apr 18, 2016

@martenson martenson merged commit f1c008b into galaxyproject:dev Apr 18, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented Apr 18, 2016

Thanks for the merge @martenson and the 🐦 👀 @nsoranzo.

@jmchilton jmchilton deleted the jmchilton:more_looks_like_tool branch Apr 18, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.