Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.01] Prepass on remote user header based on maildomain and normalize confi… #2195

Merged
merged 1 commit into from May 2, 2016

Conversation

dannon
Copy link
Member

@dannon dannon commented Apr 19, 2016

…g. This resolves an error reported on -dev with maildomain and user being set incorrectly due to changes in #1801

Refactoring and cleanup to come in current branch, not applicable to 16.01.

…g. This resolves an error reported on -dev with maildomain and user being set incorrectly.
@dannon dannon changed the title Prepass on remote user header based on maildomain and normalize confi… [16.01] [WIP] Prepass on remote user header based on maildomain and normalize confi… Apr 19, 2016
@dannon dannon changed the title [16.01] [WIP] Prepass on remote user header based on maildomain and normalize confi… [16.01] Prepass on remote user header based on maildomain and normalize confi… Apr 20, 2016
@dannon
Copy link
Member Author

dannon commented Apr 20, 2016

Swapped to review for testing. Since this will be applied to 16.01, I'm going to continue the refactoring in a separate PR; a big part of that is removing the toolshed's very slightly customized remote_user middleware and using a single consistent module and I don't want to backport that.

@dannon
Copy link
Member Author

dannon commented Apr 20, 2016

@martenson Do you know if the toolshed test that failed is one of the intermittent ones?

@martenson
Copy link
Member

yeah, that is the only one expected to fail on 16.01 (as we retroactively disabled mercurial push)

@dannon
Copy link
Member Author

dannon commented Apr 20, 2016

@martenson Awesome, thought so. Thanks for the confirmation!

@nturaga
Copy link
Contributor

nturaga commented May 2, 2016

+1

@nturaga nturaga merged commit cdea922 into galaxyproject:release_16.01 May 2, 2016
@dannon
Copy link
Member Author

dannon commented May 2, 2016

@nturaga Thanks for taking the time to test this!

@dannon
Copy link
Member Author

dannon commented May 2, 2016

(merging it forward through dev now)

@galaxybot
Copy link
Contributor

This PR was merged without a milestone attached.

@martenson martenson added this to the 16.04 milestone May 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants