Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug when determining locale #2213

Merged
merged 3 commits into from Apr 21, 2016

Conversation

Projects
None yet
3 participants
@xiaojay
Copy link
Contributor

commented Apr 21, 2016

In Simplified Chinese environment, the value of "navigator.language" is "zh-cn", which could not match the right "zh" locale.
so I created this pull request to fix this bug.

yangyuanjie yangyuanjie

@galaxybot galaxybot added the triage label Apr 21, 2016

@galaxybot galaxybot added this to the 16.07 milestone Apr 21, 2016

@dannon dannon referenced this pull request Apr 21, 2016

Merged

Building the client #1

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

@xiaojay This looks to fix it for me.

image

Our localization should probably be enhanced in the future to try to find the specific zh-cn or de-ch for example, and default to the short version zh, etc. if it is not found. But right now, we only have the base language localizations, so this works fine.

@dannon

This comment has been minimized.

Copy link
Member

commented Apr 21, 2016

@xiaojay Thanks!

@dannon dannon merged commit 266a45a into galaxyproject:dev Apr 21, 2016

1 check was pending

continuous-integration/travis-ci/pr The Travis CI build is in progress
Details

xiaojay added a commit to xiaojay/galaxy that referenced this pull request Apr 21, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.