Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[16.04] Fix js value validator #2234

Merged
merged 1 commit into from Apr 22, 2016

Conversation

guerler
Copy link
Contributor

@guerler guerler commented Apr 22, 2016

Fixes #2228

@guerler guerler changed the title Fix js value validator [16.04] Fix js value validator Apr 22, 2016
@dannon
Copy link
Member

dannon commented Apr 22, 2016

Talked with @guerler about this a bit. The fix works and I'm merging it into 16.04, but I think this needs refactoring (or at least renaming), since the validator function now returns false for empty selection arrays, which is actually a valid choice when the parameter is optional. I think that's confusing and will potentially lead to problems reusing the validate function down the road.

@dannon dannon merged commit 62bc415 into galaxyproject:release_16.04 Apr 22, 2016
@guerler
Copy link
Contributor Author

guerler commented Apr 22, 2016

Maybe we could rename it to isEmpty to make its function more obvious.

@galaxybot
Copy link
Contributor

This PR was merged without a milestone attached.

@guerler guerler added this to the 16.04 milestone Apr 22, 2016
@guerler guerler deleted the fix_validator_000 branch February 19, 2020 19:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants