Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A pass adding new contributors from 15.10->16.04(ish). #2257

Merged
merged 5 commits into from May 5, 2016

Conversation

Projects
None yet
6 participants
@dannon
Copy link
Member

commented Apr 27, 2016

Generated the list with something like:

diff <(git shortlog -se -b upstream/release_15.10 | awk '{print substr($0, index($0, $2))}') <(git shortlog -se -b upstream/dev | awk '{print substr($0, index($0, $2))}')

dannon added some commits Apr 27, 2016

@dannon dannon added status/review and removed status/WIP labels Apr 27, 2016

@dannon dannon changed the title [WIP] A pass adding new contributors from 15.10->16.04(ish). A pass adding new contributors from 15.10->16.04(ish). Apr 27, 2016

@galaxybot galaxybot added this to the 16.07 milestone Apr 27, 2016

@davebx

This comment has been minimized.

Copy link
Contributor

commented May 4, 2016

@dannon You're probably aware that this specific toolshed test is known to fail intermittently for reasons @martenson and I have yet to track down.

* Dorine Francheteau <dorine@bx.psu.edu>
* Jaime Frey <jfrey@cs.wisc.edu>
* Carrie Ganote <cganote@iu.edu>
* Ryan Golhar <ngsbioinformatics@gmail.com>
* Carie Genote <cganote@iu.edu>

This comment has been minimized.

Copy link
@martenson

martenson May 4, 2016

Member

Carrie Ganote

This comment has been minimized.

Copy link
@dannon

dannon May 4, 2016

Author Member

Hrmm. This wasn't actually changed in this PR, and was incorrect before it, and has since been fixed in -dev. I'm not sure why exactly github is showing it as a diff, but I'll make sure it doesn't get applied as such.

This comment has been minimized.

Copy link
@dannon

dannon May 4, 2016

Author Member

Cherrypicked the fix from -dev to Carrie's name so the diff looks correct now.

@@ -97,13 +111,17 @@ The following individuals have contributed code to Galaxy:
* David Trudgian <dave@trudgian.net> <david.trudgian@utsouthwestern.edu>
* Nitesh Turaga <nitesh.turaga@gmail.com>
* Clayton Turner <clayclay911@gmail.com>
* Jesse c j van Dam <jesse.vandam@wur.nl>

This comment has been minimized.

Copy link
@martenson

martenson May 4, 2016

Member

Jesse Vandam

This comment has been minimized.

Copy link
@nsoranzo

This comment has been minimized.

Copy link
@martenson

martenson May 4, 2016

Member

hmm http://www.fp7infect.eu/infect/work-package-4---wp4
the c j is also confusing, is it in the name? :D

This comment has been minimized.

Copy link
@dannon

dannon May 4, 2016

Author Member

It was in the name as he signed in his commits. Let's go with this, and if he'd like to change it that's really easy to do later.

Edit: I pinged everyone who I thought might be questionably represented

@dannon

This comment has been minimized.

Copy link
Member Author

commented May 4, 2016

Pinging the following people for clarification on their names and/or emails. Please feel free to correct me here, this was just a best guess based on how your commits were signed, derived using the command in the description.

@jessevdam
@fescudie
@xiaojay
@sokhoyan

@xiaojay

This comment has been minimized.

Copy link
Contributor

commented May 4, 2016

correct for me :)

@martenson

This comment has been minimized.

Copy link
Member

commented May 4, 2016

Thanks @dannon 👍

@martenson martenson merged commit 1809a22 into galaxyproject:dev May 5, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details

@dannon dannon referenced this pull request May 10, 2016

Merged

add Saskia to contributors #2256

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.