Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance library functions for tools. #2279

Merged
merged 3 commits into from May 2, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented May 1, 2016

  • Enhance lint and loaders to be able to handle tool parser objects instead of just raw XML. This will allow non-Galaxy-XML tool linting (e.g. CWL) and allow linters to use higher-level abstraction.
  • Replace tol-level XML linter with a "general" linter that parses attributes using the ToolSource abstraction.
  • Small updates to linting for recent additions to tool framework.
  • More docstring usage and improved import order.
  • Fixes discovered through planemo for "finding" non-XML tools.

@jmchilton jmchilton added this to the 16.07 milestone May 1, 2016

@jmchilton jmchilton force-pushed the jmchilton:lint_16.04 branch from ed7a51d to fdd556b May 1, 2016

@jmchilton jmchilton force-pushed the jmchilton:lint_16.04 branch from fdd556b to 9532c44 May 2, 2016

Enhance library functions for tools.
- Enhance lint and loaders to be able to handle tool parser objects instead of just raw XML. This will allow non-Galaxy-XML tool linting (e.g. CWL) and allow linters to use higher-level abstraction.
- Rework CWL tool loading to allow more fine-grain loading.
- Replace tol-level XML linter with a "general" linter that parses attributes using the ToolSource abstraction.
- Small updates to linting for recent additions to tool framework.
- More docstring usage and improved import order.
- Fixes discovered through planemo for "finding" non-XML tools.

@jmchilton jmchilton force-pushed the jmchilton:lint_16.04 branch from 9532c44 to 364f383 May 2, 2016

dannon and others added some commits May 2, 2016

@dannon dannon merged commit 5ff1693 into galaxyproject:dev May 2, 2016

0 of 4 checks passed

api test Test started.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test started.
Details
toolshed test Test scheduled.
Details
@jmchilton

This comment has been minimized.

Copy link
Member Author

commented May 2, 2016

Awesome - thanks a bunch for the merge and spelling fixes @dannon.

@dannon

This comment has been minimized.

Copy link
Member

commented May 2, 2016

Anytime!

@@ -1,29 +1,60 @@
"""This modules contains the functions that driving the tool linting framework."""

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo May 2, 2016

Member

"that driving": "that" should be removed on next PR.

This comment has been minimized.

Copy link
@dannon

dannon May 2, 2016

Member

Easy enough to do it now, PRs are cheap. #2289

jmchilton added a commit to jmchilton/planemo that referenced this pull request May 3, 2016

jmchilton added a commit to galaxyproject/planemo that referenced this pull request May 3, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.