Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always remove the working directory after creating the capsule archive. #2294

Merged
merged 6 commits into from May 3, 2016

Conversation

Projects
None yet
4 participants
@davebx
Copy link
Contributor

commented May 3, 2016

No description provided.

ordered_changeset_revisions ):
repository_archive, error_message = self.generate_repository_archive( ordered_repository,
ordered_changeset_revision,
work_dir )

This comment has been minimized.

Copy link
@nsoranzo

nsoranzo May 3, 2016

Member

Is it safe to reuse the same work_dir for all the archives? Previously, a new temporary directory was generated for each archive.

This comment has been minimized.

Copy link
@dannon

dannon May 3, 2016

Member

@nsoranzo yeah, I saw the same thing. generate_repository_archive walks the entire work dir it looks like, so they should not be reused. I proposed a fix in davebx#4

@dannon

This comment has been minimized.

Copy link
Member

commented May 3, 2016

@galaxybot test this

(can I trigger this directly from jenkins/travis instead of this thing?)

@dannon dannon merged commit d82b5f1 into galaxyproject:dev May 3, 2016

3 of 4 checks passed

continuous-integration/travis-ci/pr The Travis CI build failed
Details
api test Build finished.
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
@martenson

This comment has been minimized.

Copy link
Member

commented May 3, 2016

@dannon yes, while logged in you can trigger both respectively

@martenson

This comment has been minimized.

Copy link
Member

commented May 3, 2016

btw do we want to port this to 16.04? or TS will keep having this problem until 16.07....
@dannon @davebx

@dannon

This comment has been minimized.

Copy link
Member

commented May 3, 2016

Well, it isn't an active failure preventing any functionality, it's just a failure to clean up temp files when an export crashes. We can port, but until we get more disk on toolshed.g2 (or otherwise relocate the temp directory), the number one thing we need to do there is just monitor disk space and keep temp clean.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.