Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise selection, options and drilldown wrappers, add tests #2305

Merged
merged 2 commits into from May 6, 2016

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented May 4, 2016

This PR aligns the pattern/models for select fields, radio buttons, checkboxes and drilldown elements and adds 270 new test assertions.

@guerler guerler added this to the 16.07 milestone May 4, 2016

@guerler guerler force-pushed the guerler:revise_select_000 branch 5 times, most recently from d0a36ba to 30a66f4 May 4, 2016

@martenson

This comment has been minimized.

Copy link
Member

commented May 4, 2016

yay for new tests! 👻

@guerler guerler force-pushed the guerler:revise_select_000 branch 5 times, most recently from f01c43f to e845cc7 May 4, 2016

@guerler guerler force-pushed the guerler:revise_select_000 branch from e845cc7 to cfb0ddb May 5, 2016

@guerler guerler added status/review and removed status/WIP labels May 5, 2016

@martenson martenson merged commit 9955097 into galaxyproject:dev May 6, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.