Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build: remove redundant webpack step in makefile #2327

Merged
merged 1 commit into from May 10, 2016

Conversation

Projects
None yet
2 participants
@carlfeberhard
Copy link
Contributor

commented May 9, 2016

Removes the webpack make target and the 'webpack' call from client
target. The webpack production build step is already called from
the grunt step tasks.

Build: remove redundant webpack step in makefile
Removes the webpack make target and the 'webpack' call from client
target. The webpack production build step is already called from
the `grunt` step.
@dannon

This comment has been minimized.

Copy link
Member

commented May 10, 2016

Yep, #1523 made the default grunt task run webpack as well, so this step is no longer needed.

@dannon dannon merged commit 74e6d8b into galaxyproject:dev May 10, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details

@carlfeberhard carlfeberhard deleted the carlfeberhard:make.client branch May 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.