Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unicodify has different semantics to str, causing bug reporter bug #2336

Merged
merged 1 commit into from May 10, 2016

Conversation

Projects
None yet
2 participants
@erasche
Copy link
Member

commented May 10, 2016

Originally my patch was written with str()'s behaviour in mind. If a value is None, it gets cast.

I did not test my patch well enough following @nsoranzo's request to replace with galaxy.util.unicodify. Unicodify returns a real None instead of a 'None', and that gets passed to cgi.escape() which doesn't like Nones.

Unicodify has different semantics to str
Originally my patch was written with str()'s behaviour in mind. If a value is None, it gets cast.
I did not test my patch well enough following @nsoranzo's request to replace with unicodify(). In that case a raw None gets passed to cgi.escape() causing a bug

@erasche erasche added this to the 16.07 milestone May 10, 2016

@dannon

This comment has been minimized.

Copy link
Member

commented May 10, 2016

Confirmed it locally, this fixes it for me.

@dannon dannon merged commit 75a99eb into galaxyproject:dev May 10, 2016

3 of 4 checks passed

api test Test scheduled.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
@erasche

This comment has been minimized.

Copy link
Member Author

commented May 10, 2016

Thanks @dannon

@erasche erasche deleted the erasche:fix-for-the-nth-bloody-time branch Dec 19, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.