Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI & API: fix display of inaccessible datasets #2351

Merged
merged 1 commit into from May 16, 2016

Conversation

Projects
None yet
2 participants
@carlfeberhard
Copy link
Contributor

commented May 12, 2016

  • Uses contexts in serializers to restore inaccessible field of hdas
  • Overrides serialize to return only the inaccessible view of
    inaccessible hdas (no other keys are returned): 'accessible', 'id',
    'name', 'history_id', 'hid', 'history_content_type', 'state',
    'deleted', 'visible'
  • If a DatasetAssociation Backbone Model is inaccessible, considers it
    to have details preventing the (failing) GET for more details

Should be revisited if/when thread local contexts (user/session) are
working.

UI & API: fix display of inaccessible datasets
- Uses contexts in serializers to restore inaccessible field of hdas
- Overrides serialize to return only the inaccessible view of
inaccessible hdas (no other keys are returned): 'accessible', 'id',
'name', 'history_id', 'hid', 'history_content_type', 'state',
'deleted', 'visible'
- If a DatasetAssociation Backbone Model is inaccessible, considers it
to have details preventing the (failing) GET for more details

Should be revisited if/when thread local contexts (user/session) are
working.

@carlfeberhard carlfeberhard added this to the 16.07 milestone May 12, 2016

@dannon dannon merged commit 889ed25 into galaxyproject:dev May 16, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details

@carlfeberhard carlfeberhard deleted the carlfeberhard:datasets.show-inaccessible branch Jun 22, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.