Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build job success messages within tool form view #2355

Merged
merged 1 commit into from May 14, 2016

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented May 12, 2016

Since job success/error messages are specific for the corresponding tool form and not shared with other tool form variations, we should build them within the corresponding tool form view. Additionally, the tool form view should not rely on the modal view used/provided by the common form view.

@guerler guerler added this to the 16.07 milestone May 12, 2016

@guerler guerler force-pushed the guerler:revise_template_001 branch from 5a29bcc to 3f21cac May 12, 2016

@guerler guerler force-pushed the guerler:revise_template_001 branch from 3f21cac to 86050f2 May 12, 2016

@guerler guerler added status/review and removed status/WIP labels May 12, 2016

@jmchilton jmchilton merged commit b5ea024 into galaxyproject:dev May 14, 2016

4 checks passed

api test Build finished.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished.
Details
toolshed test Build finished.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.