Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revise portlet view, integrate collapsible option #2360

Merged
merged 1 commit into from May 17, 2016

Conversation

Projects
None yet
5 participants
@guerler
Copy link
Contributor

commented May 13, 2016

This PR aligns the portlet view/model pattern and extends it to natively support collapsible portlets. This features is used in tool form sections and the new run workflow form.

@jmchilton

This comment has been minimized.

Copy link
Member

commented May 14, 2016

👍

@guerler guerler force-pushed the guerler:revise_portlet_000 branch from 55d7a5f to f4c07e3 May 16, 2016

@guerler guerler force-pushed the guerler:revise_portlet_000 branch from f4c07e3 to c749e13 May 16, 2016

@guerler guerler added status/review and removed status/WIP labels May 17, 2016

@dannon dannon merged commit c749e13 into galaxyproject:dev May 17, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
@dannon

This comment has been minimized.

Copy link
Member

commented May 17, 2016

Merging locally to resolve conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.