Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with lowercasing in datatypes/registry.py #2361

Merged
merged 2 commits into from May 16, 2016

Conversation

Projects
None yet
5 participants
@remimarenco
Copy link
Contributor

commented May 14, 2016

Hi :),

I was working on changing my USCS Track Hub datatype extension and I had the (ironic) good idea to put uppercase in it.

Exceptions inside registry.py, about a KeyError. I saw that in the load_datatypes function, there is a lowercasing handling of extension name, but it does not appear then in load_display_applications.

I added the lowercasing in this last one, added a log.debug message to prevent the user it could generate issues later on, and refactored it to follow DRY.

Let me know what you think about it :)

remimarenco added some commits May 14, 2016

Fix an issue about not-lowercasing extensions in load_display_applica…
…tions. Refactored in a function the lowercasing because DRY

@galaxybot galaxybot added the triage label May 14, 2016

@galaxybot galaxybot added this to the 16.07 milestone May 14, 2016

@jmchilton

This comment has been minimized.

Copy link
Member

commented May 14, 2016

@galaxybot test this

@remimarenco

This comment has been minimized.

Copy link
Contributor Author

commented May 15, 2016

Yay all tests passed!

@nsoranzo

This comment has been minimized.

Copy link
Member

commented May 16, 2016

👍

@dannon

This comment has been minimized.

Copy link
Member

commented May 16, 2016

Thanks @remimarenco!

@dannon dannon merged commit aaff453 into galaxyproject:dev May 16, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.