Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve composite output tool test. #2363

Merged
merged 1 commit into from May 16, 2016

Conversation

Projects
None yet
3 participants
@jmchilton
Copy link
Member

commented May 16, 2016

  • Rename expected output Log from input Log. This relieves a concern I had that the tests were just working because the inputs and outputs match.
  • Add another "unregistered" output file to the output directory and add a test for it. This verifies that such files are in fact tested.
  • Add a nested "unregistered" output file to the output directory and add a test for it. This verifies that nested files are tested.

Ping @remimarenco

Improve composite output tool test.
 - Rename expected output Log from input Log. This relieves a concern I had that the tests were just working because the inputs and outputs match.
 - Add another "unregistered" output file to the output directory and add a test for it. This verifies that such files are infact tested.
 - Add a nested "unregistered" output file to the output directory and add a test for it. This verifies that nested files are tested.
@remimarenco

This comment has been minimized.

Copy link
Contributor

commented May 16, 2016

Marf...I guess I need to spend more time on this to see what it is so different between my code and this test. Thanks for taking the time @jmchilton!

@dannon dannon merged commit 28acca5 into galaxyproject:dev May 16, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.