Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docker swarm support for interactive environments #2386

Merged
merged 2 commits into from May 20, 2016

Conversation

Projects
None yet
4 participants
@jxtx
Copy link
Contributor

commented May 19, 2016

Pretty simple as it turns out. If running swarm, the Docker inspect output contains information on the node that the container is actually running on. We extract that and use it.

ping @natefoo @bgruening

@erasche

This comment has been minimized.

Copy link
Member

commented May 19, 2016

@jxtx does it work without swarm? (Even if get_container_node_ip would always return localhost?)

If so, I'd suggest just nixing the config option.

@bgruening

This comment has been minimized.

Copy link
Member

commented May 19, 2016

@jxtx nice work!
Any idea how we can support more than Swarm here? Swarm is not safe as far as I know. http://kubernetes.io/ seems to be a better bet for the moment, and I'm currently playing actually with HTCondor and Docker support.
Is this PR intended for the time being until we can get IE's into the job-runners?

@galaxybot galaxybot added the triage label May 19, 2016

@galaxybot galaxybot added this to the 16.07 milestone May 19, 2016

@erasche

This comment has been minimized.

Copy link
Member

commented May 19, 2016

(And yes, echoing @bgruening's comments, swarm is not so popular. When we move, it would be to kube/mesosphere/something other than swarm.)

@jxtx

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2016

I see no reason not to support both swarm and kube. I'll look at the API.
Merging this certainly doesn't prevent adding kube support.

On Thu, May 19, 2016 at 7:21 PM Björn Grüning notifications@github.com
wrote:

@jxtx https://github.com/jxtx nice work!
Any idea how we can support more than Swarm here? Swarm is not safe as far
as I know. http://kubernetes.io/ seems to be a better bet for the moment,
and I'm currently playing actually with HTCondor and Docker support.
Is this PR intended for the time being until we can get IE's into the
job-runners?


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2386 (comment)

@jxtx

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2016

That node doesn't exist in regular docker inspect. I'm happy to just test
for its existence and default to localhost.

On Thu, May 19, 2016 at 7:21 PM Eric Rasche notifications@github.com
wrote:

@jxtx https://github.com/jxtx does it work without swarm? (Even if
get_container_node_ip would always return localhost?)

If so, I'd suggest just nixing the config option.


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2386 (comment)

@jxtx jxtx changed the title [wip] Docker swarm support for interactive environments Docker swarm support for interactive environments May 20, 2016

@jxtx

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2016

Updated to not use a config parameter per @erasche

@jxtx jxtx added status/review and removed status/WIP labels May 20, 2016

@erasche

This comment has been minimized.

Copy link
Member

commented May 20, 2016

@jxtx awesome! Looks great!

@erasche erasche merged commit 4f3e0f6 into galaxyproject:dev May 20, 2016

0 of 4 checks passed

api test Test scheduled.
Details
continuous-integration/travis-ci/pr The Travis CI build is in progress
Details
framework test Test scheduled.
Details
toolshed test Test scheduled.
Details

bgruening added a commit that referenced this pull request May 20, 2016

@bgruening

This comment has been minimized.

Copy link
Member

commented May 20, 2016

@jxtx this is great!
I hope I'm right that your recent work is intended to get IEs on usegalaxy.org in a more stable state :)

This PR fixes hopefully the failing tests here.
#2392

Thanks again!

erasche added a commit that referenced this pull request May 20, 2016

@jxtx

This comment has been minimized.

Copy link
Contributor Author

commented May 20, 2016

I hope I'm right that your recent work is intended to get IEs on usegalaxy.org in a more stable state :)

Exactly that! Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.