Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for EDAM data annotations to datatypes #2387

Merged
merged 17 commits into from May 20, 2016

Conversation

Projects
None yet
5 participants
@nsoranzo
Copy link
Member

commented May 20, 2016

This is an outcome of the Technical Hackathon: Tools, Workflows and Workbenches and contains work by @bgruening, @hmenager, @mvdbeek and me.

It contains a subset of PR #1891 which should be immediately mergeable.

@@ -19,7 +19,9 @@

class Amos( data.Text ):
"""Class describing the AMOS assembly file """
edam_format = "format_2561"

This comment has been minimized.

Copy link
@mvdbeek

mvdbeek May 20, 2016

Member

let's remove that blank line

@bgruening

This comment has been minimized.

Copy link
Member

commented May 20, 2016

Lovely! Thanks so much for finishing it!
I would remove some blank-lines but this is just my taste. Let's merge this if the tests are passing!

Thanks again!

@nsoranzo

This comment has been minimized.

Copy link
Member Author

commented May 20, 2016

@bgruening Blank lines removed.

@bgruening bgruening merged commit 1b7c439 into galaxyproject:dev May 20, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
@bgruening

This comment has been minimized.

Copy link
Member

commented May 20, 2016

Great work!

@nsoranzo nsoranzo deleted the nsoranzo:edam_data branch May 20, 2016

@nsoranzo nsoranzo referenced this pull request May 20, 2016

Open

[WIP] Biotools #1891

@hmenager

This comment has been minimized.

Copy link
Contributor

commented May 20, 2016

Thank you so much everyone for getting this done! Great team work indeed!

On Fri, May 20, 2016 at 11:58 AM Björn Grüning notifications@github.com
wrote:

Great work!


You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub
#2387 (comment)

@jmchilton

This comment has been minimized.

Copy link
Member

commented May 20, 2016

Awesome sauce - thanks all!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.