Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a new workflow building mode variation which does access the history #2390

Merged
merged 1 commit into from May 23, 2016

Conversation

Projects
None yet
2 participants
@guerler
Copy link
Contributor

commented May 20, 2016

This PR adds a new workflow building mode variation to the tool framework. In contrast to the regular workflow building mode used in the workflow editor, this 2nd variation accesses the history which is necessary when building a workflow form for execution. This PR also relabels the flag name in to_json from workflow_mode to workflow_building_mode for consistency.

@guerler guerler added this to the 16.07 milestone May 20, 2016

@guerler guerler force-pushed the guerler:revise_tool_framework_000 branch 2 times, most recently from 58a405d to 085251a May 20, 2016

@guerler guerler force-pushed the guerler:revise_tool_framework_000 branch from 085251a to 9d56eaf May 21, 2016

@guerler guerler added status/review and removed status/WIP labels May 21, 2016

@jmchilton

This comment has been minimized.

Copy link
Member

commented May 23, 2016

USE_HISTORY doesn't seem to be used anywhere - is there something missing from this commit?

@guerler

This comment has been minimized.

Copy link
Contributor Author

commented May 23, 2016

Yes, the feature is prepared/introduced here but not yet used. It will be used to build the new run workflow form. Hmm I can see that this is not optimal tho. If you do not like this, I can combine it with the js-part which utilizes this feature. My intention was to separate this since it is purely a framework extension and effects shared code. As always, thanks a lot for looking into this. Its greatly appreciated.

@jmchilton jmchilton merged commit fa77c8f into galaxyproject:dev May 23, 2016

4 checks passed

api test Build finished. 213 tests run, 0 skipped, 0 failed.
Details
continuous-integration/travis-ci/pr The Travis CI build passed
Details
framework test Build finished. 105 tests run, 0 skipped, 0 failed.
Details
toolshed test Build finished. 581 tests run, 0 skipped, 0 failed.
Details
@jmchilton

This comment has been minimized.

Copy link
Member

commented May 23, 2016

I was just curious - looks fine to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.